Fix framework identity interceptor #44518
Merged
+235
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
github-actions
bot
added
provider
jar-b
previously approved these changes
Oct 8, 2025
There was a problem hiding this comment.
LGTM 🚀
% make t K=ec2 T=TestAccVPCSecurityGroupIngressRule_Identity
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 b-identity-for-framework 🌿...
TF_ACC=1 go1.24.6 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCSecurityGroupIngressRule_Identity' -timeout 360m -vet=off
2025/10/08 10:02:46 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/08 10:02:46 Initializing Terraform AWS Provider (SDKv2-style)...
--- PASS: TestAccVPCSecurityGroupIngressRule_Identity_RegionOverride (31.91s)
--- PASS: TestAccVPCSecurityGroupIngressRule_Identity_Basic (37.47s)
--- PASS: TestAccVPCSecurityGroupIngressRule_Identity_ExistingResource_NoRefresh_NoChange (52.26s)
--- PASS: TestAccVPCSecurityGroupIngressRule_Identity_ExistingResource (60.43s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 68.051s
jar-b
reviewed
Oct 8, 2025
Co-authored-by: Jared Baker <[email protected]>
github-actions
bot
added
tests
jar-b
reviewed
Oct 8, 2025
jar-b
approved these changes
Oct 8, 2025
|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Relations
Relates #44375
References
Output from Acceptance Testing